test(mcp-test): deflake streamable HTTP version-negotiation integration test - #1113
Open
slachiewicz wants to merge 1 commit into
Open
test(mcp-test): deflake streamable HTTP version-negotiation integration test#1113slachiewicz wants to merge 1 commit into
slachiewicz wants to merge 1 commit into
Conversation
…on test - tolerate an absent MCP-Protocol-Version header in the context extractor: Map.of rejects null values while spec-correct clients legitimately omit the header on initialize requests - await the asynchronously opened GET /mcp stream before asserting recorded calls; observed intermittently in CI as AssertionError Expected size: 3 but was: 2 (evidence: actions/run/33069467622 Jackson 2 Integration Tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent timing hazards cause intermittent CI failures:
Change: null-safe extractor (Objects.requireNonNullElse) + Awaitility guard for the recorded GET.
Tested: ./mvnw -pl mcp-test -am test -Dtest=HttpClientStreamableHttpVersionNegotiationIntegrationTests → 2/2 green; no production code touched.